Commit Graph
1254 Commits
Author SHA1 Message Date
Samuel Holland ea9b6639c6 PowerPC bugfixes (#520)
* powerpc: Silence warnings about unused labels

* powerpc: Fix a couple of comments

* powerpc: Fix alignment after float structs

* powerpc: Don't pad rvalues copied from FP regs

* powerpc: Add missing check in struct alignment

* powerpc: Support homogeneous long double structs
2019-10-08 06:57:28 -04:00
Anthony Green 25cf9cc4a5 Use https for moxie toolchain repo 2019-10-08 06:24:55 -04:00
Paul Monson c2a6859012 fix mingw build and crashing bugs for Python Windows ARM64 (#496)
* fix mingw build and crashing bugs for Python Windows ARM64

* Fix issues found in PR review
2019-08-07 14:57:45 -04:00
Anthony Green e0b4f84fb7 Clear the apt cache 2019-06-26 06:18:48 -04:00
Anthony Green 68668fe4f2 More debugging output 2019-06-26 06:01:15 -04:00
Anthony Green 1d7635d18a Debug moxie builds in travis 2019-06-25 23:39:52 -04:00
ossdev07 d856743e6b libffi: added ARM64 support for Windows (#486)
*  libffi: added ARM64 support for Windows

    1. ported sysv.S to win64_armasm.S for armasm64 assembler
    2. added msvc_build folder for visual studio solution
    3. updated README.md for the same
    4. MSVC solution created with the changes, and below test suites are tested
       with test script written in python.

       libffi.bhaible
       libffi.call
    5. Basic functionality of above test suites are getting passed

Signed-off-by: ossdev07 <ossdev@puresoftware.com>

* Update README.md
2019-06-25 22:01:22 -04:00
Anthony Green 80d07104c3 uuencode compressed log files for travis 2019-04-28 07:36:24 -04:00
Sergei Trofimovich fadf1eb530 hppa: avoid TEXTREL in .eh_frame section (#447)
Before the change hand-crafted .eh_frame section contained
ABS relocation and caused TEXTREL tag to be emitted:

```
$ ./configure --host=hppa2.0-unknown-linux-gnu LDFLAGS=-Wl,-z,text
$ make
...
/usr/libexec/gcc/hppa2.0-unknown-linux-gnu/ld:
    read-only segment has dynamic relocations.
```

Link failure is caused by absolute address of FDEs
encoded into .eh_frame entries.

Fixed TEXTREL by using pcrel (instead of ABS) encoding
for absolute addresses (__PIC__ code) by adding augmentation
information ("zR" CIE type).

All tests still pass on hppa2.0. The specific tests that still pass
and exercise this code path:
    testsuite/libffi.call/unwindtest.cc
    testsuite/libffi.call/unwindtest_ffi_call.cc

Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
2019-04-27 15:53:28 -04:00
driver1998 06bf1a9dea fix x86/x64 MSVC build (#487) 2019-04-27 15:21:44 -04:00
Paul Monson db5706ff28 add support for 32-bit ARM on Windows (#477)
* add support for 32-bit ARM on Windows

* fix mismatched brace in appveyor.yml

* remove arm platform from appveyor.yml for now

* fix arm build

* fix typo

* fix assembler names

* try Visual Studio 2017

* add windows arm32 to .appveyor.yml

* update README.md
2019-04-26 07:58:58 -04:00
Tom Tromey d1e9b4b96c Merge pull request #482 from sharkcz/aarch64
fix check for Linux/aarch64
2019-04-09 14:00:10 -06:00
Dan Horák a7d6396f06 fix check for Linux/aarch64
fixes #473
2019-03-29 14:19:20 +01:00
Jeremy Huddleston Sequoia 05a1796419 Cleanup symbol exports on darwin and add architecture preprocessor checks to assist in building fat binaries (eg: i386+x86_64 on macOS or arm+aarch64 on iOS) (#450)
* x86: Ensure _efi64 suffixed symbols are not exported

* x86: Ensure we do not export ffi_prep_cif_machdep

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

* x86: Ensure we don't export ffi_call_win64, ffi_closure_win64, or ffi_go_closure_win64

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

* closures: Silence a semantic warning

libffi/src/closures.c:175:23: This function declaration is not a prototype

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

* aarch64: Ensure we don't export ffi_prep_cif_machdep

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

* arm: Ensure we don't export ffi_prep_cif_machdep

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

* aarch64, arm, x86: Add architecture preprocessor checks to support easier fat builds (eg: iOS)

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

* x86: Silence some static analysis warnings

libffi/src/x86/ffi64.c:286:21: The left operand of '!=' is a garbage value due to array index out of bounds
libffi/src/x86/ffi64.c:297:22: The left operand of '!=' is a garbage value due to array index out of bounds

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

* aarch: Use FFI_HIDDEN rather than .hidden

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

* ffi.h: Don't advertise ffi_java_rvalue_to_raw, ffi_prep_java_raw_closure, and ffi_prep_java_raw_closure_loc when FFI_NATIVE_RAW_API is 0

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2019-02-19 07:11:28 -05:00
dabrain34 3ec522bc1c Fix cfi checks for old compiler (#453)
cfi_sections can be unsupported when cfi_startproc
and cfi_endproc are.
2019-02-19 07:09:09 -05:00
Paul Monson e1118af505 changes for win32 on windows (#468) 2019-02-19 06:58:25 -05:00
Florian Weimer 44a6c28545 aarch64: Flush code mapping in addition to data mapping (#471)
This needs a new function, ffi_data_to_code_pointer, to translate
from data pointers to code pointers.

Fixes issue #470.
2019-02-19 06:55:11 -05:00
Anthony Green 042ef8c314 Remove -Os testing. No ABI impact, and helps trim log lengths. 2019-02-12 08:52:18 -05:00
Tom Tromey 8fa88373a1 Merge pull request #461 from NativeScript/bektchiev/fix-visibility-hidden-check-in-configure
fix(configure): Correctly detect visibility("hidden") support on Darwin
2018-12-19 14:18:40 -07:00
Martin Bektchiev 2c5b164288 fix(configure): Correctly detect visibility("hidden") support on Darwin 2018-12-19 18:36:25 +02:00
Tom Tromey 737d4faa00 Merge pull request #457 from NativeScript/bektchiev/fix-arm64-q3-q4-args
Fix Q registers parameter passing on ARM64
2018-11-30 08:16:00 -07:00
Martin Bektchiev 4a84df4ae9 Fix Q registers parameter passing on ARM64
The second two quads are located at offset 32 not 16
2018-10-31 16:25:05 +02:00
Tom Tromey a5ea7527cd Merge pull request #443 from jeremyhu/master
Update FFI_HIDDEN() to use .private_extern on Apple platforms and use the macro where appropriate
2018-09-19 07:29:36 -06:00
Tom Tromey b11b08ca8d Merge pull request #449 from gpakosz/align-macros
Prefix ALIGN_DOWN macro with FFI_
2018-09-18 08:26:31 -06:00
Gregory Pakosz e6eac7863e Prefix ALIGN_DOWN macro with FFI_ 2018-09-18 15:19:53 +02:00
Tom Tromey 980908b47b Merge pull request #445 from andreas-schwab/master
RISC-V go closures
2018-08-11 09:53:15 -06:00
Andreas Schwab 4cb776bc80 RISC-V go closures
This implements go closures for RISC-V.  It has been tested on
riscv64-suse-linux and against the libgo testsuite.
2018-08-09 15:41:17 +02:00
Jeremy Huddleston Sequoia ba73a671cb Update FFI_HIDDEN() to use .private_extern on Apple platforms and use the macro where appropriate
Fix issue #439

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>
2018-07-21 14:36:10 -07:00
Jeremy Huddleston Sequoia 65da63abc8 Add compact unwind for darwin/i386 (#440)
* x86: Add implementation of compact unwind for ffi_call_i386, et al.

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>

* x86: Use __text as the section name to avoid deprecated section name warnings.

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>

* darwin: Add missing regular,debug attributes for compact unwind sections

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>
2018-06-25 07:38:58 -04:00
Shoaib Meenai 2309b58448 Mark sysv.S as SafeSEH compatible (#438)
It contains no exception handler, so we can just emit the special
@feat.00 symbol to indicate that it's trivially SafeSEH compatible.
SafeSEH only applies to x86 and not x86-64, hence its inclusion in the
x86-specific block. See [1] for details.

[1] https://msdn.microsoft.com/en-us/library/windows/desktop/ms680547(v=vs.85).aspx#the_.sxdata_section_
2018-06-17 20:04:24 -04:00
Jeremy Huddleston Sequoia 1d704051b2 i386: Fix missing break; in case statement leading to incorrectly returned FFI_BAD_ABI (#437)
* i386: Add missing break triggering dead store static analyzer checks.

Register calling sequence is being reported as bad ABI instead of working as intended.

Found-by: Clang Static Analysis
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>

* Mark ffi arm sysv entry points as private_extern.

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>

* x86_64: Add implementation of compact unwind for ffi_call_unix64.

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2018-06-17 20:01:50 -04:00
Anthony Green b55baf0b50 Handle FFI_GNUW64 on non-Windows systems (EFI) 2018-05-09 13:21:02 -04:00
Anthony Green 8206253fdf Mark some cases as xfail due to GCC bug 2018-05-09 10:50:46 -04:00
Anthony Green b5ee395710 Revert "Remove some symbol exports and cleanup newline warnings (#433)"
This reverts commit a5a0f3cf36.
2018-05-05 07:41:53 -04:00
Jeremy Huddleston Sequoia a5a0f3cf36 Remove some symbol exports and cleanup newline warnings (#433)
* build: Ensure darwin generated sources end with a new line

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>

* build: Use .private_extern where missing to prevent exporting symbols that are not API

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>
2018-05-05 06:44:33 -04:00
hjl-tools d3c54cf3a2 Re-enable msabi testing (#436)
* Revert "disable msabi testing for now"

This reverts commit 7b7638eb0e.

* x86: Correct testing for 64-bit x86-64

Since passing -m32 to x86-64 compiler will generate i386 code, we
need to check both __ILP32__ and __i386__ for 64-bit x86-64.

* x86: Check __i386__ instead of i?86-*-* targets

Since passing -m32 to x86-64 compiler will generate i386 code, we need
to check __i386__ instead of i?86-*-* targets for i386 targets.

* i386: Properly passing integer parameters in registers

For thiscall and fastcall, if the paramter passed as 64-bit integer or
struct, all following integer paramters will be passed on stack.

* test: Add ABI_ATTR to callback_code

Add ABI_ATTR to callback_code to properly test different ABIs.
2018-05-02 09:19:58 -04:00
Alan Modra ebf241663c PowerPC64 ELFv1 fp arg fixes
The ELFv1 ABI says: "Single precision floating point values are mapped
to the second word in a single doubleword" and also "Floating point
registers f1 through f13 are used consecutively to pass up to 13
floating point values, one member aggregates passed by value
containing a floating point value, and to pass complex floating point
values".

libffi wasn't expecting float args in the second word, and wasn't
passing one member aggregates in fp registers.  This patch fixes those
problems, making use of the existing ELFv2 homogeneous aggregate
support since a one element fp struct is a special case of an
homogeneous aggregate.

I've also set a flag when returning pointers that might be used one
day.  This is just a tidy since the ppc64 assembly support code
currently doesn't test FLAG_RETURNS_64BITS for integer types..

	* src/powerpc/ffi_linux64.c (discover_homogeneous_aggregate):
	Compile for ELFv1 too, handling single element aggregates.
	(ffi_prep_cif_linux64_core): Call discover_homogeneous_aggregate
	for ELFv1.  Set FLAG_RETURNS_64BITS for FFI_TYPE_POINTER return.
	(ffi_prep_args64): Call discover_homogeneous_aggregate for ELFv1,
	and handle single element structs containing float or double
	as if the element wasn't wrapped in a struct.  Store floats in
	second word of doubleword slot when big-endian.
	(ffi_closure_helper_LINUX64): Similarly.
2018-05-02 07:14:39 -04:00
Anthony Green a2c6c7af9f Add license for build-time tools 2018-05-01 06:46:30 -04:00
Tom Tromey 4c2206ace0 Fix two "return" issues in x86/ffi64.c (#431)
Issue #70 pointed out that at least one compiler didn't like:

    return ffi_call_efi64(cif, fn, rvalue, avalue);

... where the return type is "void".  This patch splits the statement
into two.

I also noticed that ffi_call_go here seems to do a double call.  I
suspect a "return" is missing here, so this patch adds it as well.
2018-04-28 06:46:10 -04:00
Tom Tromey ed3ed4d801 Merge pull request #429 from yousong/m4subst
build: fix subst toolexecdir, toolexeclibdir
2018-04-27 10:48:51 -06:00
Yousong Zhou b69f95d656 build: fix subst toolexecdir, toolexeclibdir
On CentOS 7.4, configure script generated by autogen.sh will output the
following values when compiling GCC source code

    toolexecdir='NONE/$(target_alias)'
    toolexeclibdir='NONE/$(target_alias)/lib'

and cause build error

    ... -o libffi.la -rpath NONE/riscv64-bs-linux-gnu/lib ...
    checking for shl_load in -ldld... libtool: link: only absolute run-paths are allowed
2018-04-27 09:39:19 +08:00
Stephen 8e250c390a update to https for cygwin download (#428) 2018-04-25 16:17:32 -04:00
Lucas Pluvinage 7d3cab7926 xtensa-linux: use cache flush instruction only if it is available (#426) 2018-04-20 18:24:50 -04:00
James Cowgill 159b94e5fd Various MIPS Fixes (#425)
* mips: simplify closure #defines

This commit should have no visible effect.

* mips: add special handling of variadic functions

MIPS requires special handling of variadic functions which pass floating
point arguments:
* In the o32 ABI, all float arguments are passed in integer registers.
* In the n32/n64 ABIs, float arguments after the ellipsis are passed in
  integer registers.

Implement this in libffi. To support this in n32/n64 closures, we need to add
a new mips_nfixedargs field to ffi_cif which will break the libffi ABI.

This fixes the libffi.call/cls_longdouble_va.c test which was failing on
64-bit MIPS.

* mips: align argn for all 64-bit types in o32 closure handler

Ensure that argn is pre-aligned for all 64-bit argument types (including
doubles) and not just integer types.

This fixes closures of the form "f(float, double, <some integer args>)".
Previously the first integer argument would be read from a2 which is garbage
at this point (the float arguments have already "consumed" a0-a3). After
this commit, argn is correctly padded between the "float" and "double"
arguments so that the first integer argument is read from the stack.

Fixes "double f(float,double,int)" test in #371

* mips: do not read from floating point register if returning a struct

In the o32 ABI, the pointer passed in a0 used to return structures
indirectly is treated as the first argument for argument allocation purposes.
This means that it should inhibit floating point registers the same way that
other integer arguments do.

Fixes "Double f(float,Double,double)" test in #371

* mips: fix pointer cast warnings

Fix two pointer cast warnings when compiled on 64-bit mips by casting
through uintptr_t.

Fixes mips64el part of #404
2018-04-18 20:28:23 -04:00
Anthony Green f2afda08e8 Merge branch 'master' of github.com:/libffi/libffi 2018-04-08 18:25:43 -04:00
Anthony Green e27f70b8cf Fix case where callback arg value is split across regs and stack 2018-04-08 18:25:34 -04:00
Andreas Krebbel 801c1bd712 Fix issue #421 (#422)
Fantastic - thanks for digging into this.
2018-04-05 07:27:32 -05:00
Anthony Green 8660e69359 3.3 release candidate 0 2018-04-02 08:30:17 -04:00
Anthony Green 7b7638eb0e disable msabi testing for now 2018-04-02 08:24:44 -04:00
fwg af6773d6ab Fix appveyor windows build (#420)
* Fix msvcc dll build by adding dllexport decorations to all API declarations

* Fix appveyor build for VS 2013

Use the new -DFFI_BUILDING_DLL for producing a working DLL. Update the
msvcc.sh wrapper script to successfully compile the testsuite files.

* MSVC build: suppress warnings in testsuite

* fix testsuite on appveyor
2018-04-02 06:55:31 -05:00