Commit Graph
1226 Commits
Author SHA1 Message Date
Jeremy Huddleston Sequoia 65da63abc8 Add compact unwind for darwin/i386 (#440)
* x86: Add implementation of compact unwind for ffi_call_i386, et al.

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>

* x86: Use __text as the section name to avoid deprecated section name warnings.

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>

* darwin: Add missing regular,debug attributes for compact unwind sections

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>
2018-06-25 07:38:58 -04:00
Shoaib Meenai 2309b58448 Mark sysv.S as SafeSEH compatible (#438)
It contains no exception handler, so we can just emit the special
@feat.00 symbol to indicate that it's trivially SafeSEH compatible.
SafeSEH only applies to x86 and not x86-64, hence its inclusion in the
x86-specific block. See [1] for details.

[1] https://msdn.microsoft.com/en-us/library/windows/desktop/ms680547(v=vs.85).aspx#the_.sxdata_section_
2018-06-17 20:04:24 -04:00
Jeremy Huddleston Sequoia 1d704051b2 i386: Fix missing break; in case statement leading to incorrectly returned FFI_BAD_ABI (#437)
* i386: Add missing break triggering dead store static analyzer checks.

Register calling sequence is being reported as bad ABI instead of working as intended.

Found-by: Clang Static Analysis
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>

* Mark ffi arm sysv entry points as private_extern.

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>

* x86_64: Add implementation of compact unwind for ffi_call_unix64.

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2018-06-17 20:01:50 -04:00
Anthony Green b55baf0b50 Handle FFI_GNUW64 on non-Windows systems (EFI) 2018-05-09 13:21:02 -04:00
Anthony Green 8206253fdf Mark some cases as xfail due to GCC bug 2018-05-09 10:50:46 -04:00
Anthony Green b5ee395710 Revert "Remove some symbol exports and cleanup newline warnings (#433)"
This reverts commit a5a0f3cf36.
2018-05-05 07:41:53 -04:00
Jeremy Huddleston Sequoia a5a0f3cf36 Remove some symbol exports and cleanup newline warnings (#433)
* build: Ensure darwin generated sources end with a new line

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>

* build: Use .private_extern where missing to prevent exporting symbols that are not API

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>
2018-05-05 06:44:33 -04:00
hjl-tools d3c54cf3a2 Re-enable msabi testing (#436)
* Revert "disable msabi testing for now"

This reverts commit 7b7638eb0e.

* x86: Correct testing for 64-bit x86-64

Since passing -m32 to x86-64 compiler will generate i386 code, we
need to check both __ILP32__ and __i386__ for 64-bit x86-64.

* x86: Check __i386__ instead of i?86-*-* targets

Since passing -m32 to x86-64 compiler will generate i386 code, we need
to check __i386__ instead of i?86-*-* targets for i386 targets.

* i386: Properly passing integer parameters in registers

For thiscall and fastcall, if the paramter passed as 64-bit integer or
struct, all following integer paramters will be passed on stack.

* test: Add ABI_ATTR to callback_code

Add ABI_ATTR to callback_code to properly test different ABIs.
2018-05-02 09:19:58 -04:00
Alan Modra ebf241663c PowerPC64 ELFv1 fp arg fixes
The ELFv1 ABI says: "Single precision floating point values are mapped
to the second word in a single doubleword" and also "Floating point
registers f1 through f13 are used consecutively to pass up to 13
floating point values, one member aggregates passed by value
containing a floating point value, and to pass complex floating point
values".

libffi wasn't expecting float args in the second word, and wasn't
passing one member aggregates in fp registers.  This patch fixes those
problems, making use of the existing ELFv2 homogeneous aggregate
support since a one element fp struct is a special case of an
homogeneous aggregate.

I've also set a flag when returning pointers that might be used one
day.  This is just a tidy since the ppc64 assembly support code
currently doesn't test FLAG_RETURNS_64BITS for integer types..

	* src/powerpc/ffi_linux64.c (discover_homogeneous_aggregate):
	Compile for ELFv1 too, handling single element aggregates.
	(ffi_prep_cif_linux64_core): Call discover_homogeneous_aggregate
	for ELFv1.  Set FLAG_RETURNS_64BITS for FFI_TYPE_POINTER return.
	(ffi_prep_args64): Call discover_homogeneous_aggregate for ELFv1,
	and handle single element structs containing float or double
	as if the element wasn't wrapped in a struct.  Store floats in
	second word of doubleword slot when big-endian.
	(ffi_closure_helper_LINUX64): Similarly.
2018-05-02 07:14:39 -04:00
Anthony Green a2c6c7af9f Add license for build-time tools 2018-05-01 06:46:30 -04:00
Tom Tromey 4c2206ace0 Fix two "return" issues in x86/ffi64.c (#431)
Issue #70 pointed out that at least one compiler didn't like:

    return ffi_call_efi64(cif, fn, rvalue, avalue);

... where the return type is "void".  This patch splits the statement
into two.

I also noticed that ffi_call_go here seems to do a double call.  I
suspect a "return" is missing here, so this patch adds it as well.
2018-04-28 06:46:10 -04:00
Tom Tromey ed3ed4d801 Merge pull request #429 from yousong/m4subst
build: fix subst toolexecdir, toolexeclibdir
2018-04-27 10:48:51 -06:00
Yousong Zhou b69f95d656 build: fix subst toolexecdir, toolexeclibdir
On CentOS 7.4, configure script generated by autogen.sh will output the
following values when compiling GCC source code

    toolexecdir='NONE/$(target_alias)'
    toolexeclibdir='NONE/$(target_alias)/lib'

and cause build error

    ... -o libffi.la -rpath NONE/riscv64-bs-linux-gnu/lib ...
    checking for shl_load in -ldld... libtool: link: only absolute run-paths are allowed
2018-04-27 09:39:19 +08:00
Stephen 8e250c390a update to https for cygwin download (#428) 2018-04-25 16:17:32 -04:00
Lucas Pluvinage 7d3cab7926 xtensa-linux: use cache flush instruction only if it is available (#426) 2018-04-20 18:24:50 -04:00
James Cowgill 159b94e5fd Various MIPS Fixes (#425)
* mips: simplify closure #defines

This commit should have no visible effect.

* mips: add special handling of variadic functions

MIPS requires special handling of variadic functions which pass floating
point arguments:
* In the o32 ABI, all float arguments are passed in integer registers.
* In the n32/n64 ABIs, float arguments after the ellipsis are passed in
  integer registers.

Implement this in libffi. To support this in n32/n64 closures, we need to add
a new mips_nfixedargs field to ffi_cif which will break the libffi ABI.

This fixes the libffi.call/cls_longdouble_va.c test which was failing on
64-bit MIPS.

* mips: align argn for all 64-bit types in o32 closure handler

Ensure that argn is pre-aligned for all 64-bit argument types (including
doubles) and not just integer types.

This fixes closures of the form "f(float, double, <some integer args>)".
Previously the first integer argument would be read from a2 which is garbage
at this point (the float arguments have already "consumed" a0-a3). After
this commit, argn is correctly padded between the "float" and "double"
arguments so that the first integer argument is read from the stack.

Fixes "double f(float,double,int)" test in #371

* mips: do not read from floating point register if returning a struct

In the o32 ABI, the pointer passed in a0 used to return structures
indirectly is treated as the first argument for argument allocation purposes.
This means that it should inhibit floating point registers the same way that
other integer arguments do.

Fixes "Double f(float,Double,double)" test in #371

* mips: fix pointer cast warnings

Fix two pointer cast warnings when compiled on 64-bit mips by casting
through uintptr_t.

Fixes mips64el part of #404
2018-04-18 20:28:23 -04:00
Anthony Green f2afda08e8 Merge branch 'master' of github.com:/libffi/libffi 2018-04-08 18:25:43 -04:00
Anthony Green e27f70b8cf Fix case where callback arg value is split across regs and stack 2018-04-08 18:25:34 -04:00
Andreas Krebbel 801c1bd712 Fix issue #421 (#422)
Fantastic - thanks for digging into this.
2018-04-05 07:27:32 -05:00
Anthony Green 8660e69359 3.3 release candidate 0 2018-04-02 08:30:17 -04:00
Anthony Green 7b7638eb0e disable msabi testing for now 2018-04-02 08:24:44 -04:00
fwg af6773d6ab Fix appveyor windows build (#420)
* Fix msvcc dll build by adding dllexport decorations to all API declarations

* Fix appveyor build for VS 2013

Use the new -DFFI_BUILDING_DLL for producing a working DLL. Update the
msvcc.sh wrapper script to successfully compile the testsuite files.

* MSVC build: suppress warnings in testsuite

* fix testsuite on appveyor
2018-04-02 06:55:31 -05:00
Anthony Green 48bdb02867 Trim some optimization tests 2018-03-29 07:22:57 -04:00
Anthony Green f98e0f0d77 Simplify matrix 2018-03-29 07:22:38 -04:00
Anthony Green fa72b054e1 Remove warning message from clang 2018-03-29 07:10:23 -04:00
Anthony Green 746c3ce220 Expand ABI tests on x86. Testsuite bug fixes. 2018-03-29 07:01:14 -04:00
Anthony Green 2eee934d0c deal with msvc warnings 2018-03-27 14:45:40 -04:00
Anthony Green 206b2974f7 fix quoting issue 2018-03-27 14:37:50 -04:00
Anthony Green 499e41c1ec Don't ignore a file 2018-03-27 14:35:10 -04:00
Anthony Green 5b41e9f6d2 Try different msvc hack 2018-03-27 14:34:31 -04:00
Anthony Green e8cf133813 msvc c99 hack 2018-03-27 14:12:02 -04:00
Anthony Green a3e2094089 More msvc hacks 2018-03-27 11:58:42 -04:00
Anthony Green a82b456e98 msvc fixes 2018-03-27 11:49:46 -04:00
Anthony Green a2326aaf56 Remove debug output 2018-03-27 11:36:04 -04:00
Anthony Green 85b6b209d7 Force literals to float (msvc warning) 2018-03-27 11:35:23 -04:00
Anthony Green 2872c460ba Fix msvc linking 2018-03-27 11:28:40 -04:00
Anthony Green b40a386c22 Fix library path handling 2018-03-27 11:20:21 -04:00
Anthony Green d78c5f64f8 Deal with libpath 2018-03-27 11:14:56 -04:00
Anthony Green f318bb63c5 Fix library path handling 2018-03-27 08:25:26 -04:00
Anthony Green 4f0c9cb39b Use mixed cygpath paths 2018-03-27 08:10:03 -04:00
Anthony Green d3693b4665 Copy - don't symlink - to support msvc builds 2018-03-27 08:05:42 -04:00
Anthony Green 51ce3696cd Use cygpath to convert windows paths 2018-03-27 07:35:33 -04:00
Anthony Green 70b93e4d86 try to fix windows builds 2018-03-27 07:14:59 -04:00
Anthony Green 377134d7a9 Reduce verbosity 2018-03-27 07:06:01 -04:00
Anthony Green d01ef5b875 iOS builds 2018-03-27 06:23:29 -04:00
Anthony Green d13583f55f Fix -L support 2018-03-27 06:22:57 -04:00
Anthony Green d49911544b Fix quoting 2018-03-27 05:59:26 -04:00
Anthony Green 8f47ec404f Don't set AM_MAKEFLAGS 2018-03-27 05:35:35 -04:00
Anthony Green df314193dc Run tests with lots of debug output 2018-03-27 05:13:38 -04:00
Anthony Green b394947518 Add -L and -l support 2018-03-27 05:11:52 -04:00