samsonium/libffi
1
0
Fork 0
mirror of https://github.com/partic2/libffi synced 2026-11-11 02:27:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

i386: Fix missing break; in case statement leading to incorrectly returned FFI_BAD_ABI (#437)

Browse Source 
* i386: Add missing break triggering dead store static analyzer checks.

Register calling sequence is being reported as bad ABI instead of working as intended.

Found-by: Clang Static Analysis
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>

* Mark ffi arm sysv entry points as private_extern.

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@macports.org>

* x86_64: Add implementation of compact unwind for ffi_call_unix64.

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
This commit is contained in:
Jeremy Huddleston Sequoia
2018-06-17 20:01:50 -04:00
committed by Anthony Green
parent b55baf0b50
commit 1d704051b2
3 changed files with 43 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/x86/ffi.c
+1
View File
@@ -545,6 +545,7 @@ ffi_prep_closure_loc (ffi_closure* closure,
case FFI_REGISTER:
dest = ffi_closure_REGISTER;
op = 0x68; /* pushl imm */
break;
default:
return FFI_BAD_ABI;
}