Base implementation #1

Merged
Dmitriy merged 9 commits from base-impl into master 2026-09-29 14:25:08 +00:00
8 changed files with 41 additions and 19 deletions
Showing only changes of commit 433407cc9d - Show all commits
+2 -1
View File
@@ -8,7 +8,8 @@
#include <vector> #include <vector>
/// Magic Srolls engine core /// Magic Srolls engine core
class MscEngine : public IMscEngineModuleAPI { class MscEngine : public IMscEngineModuleAPI
{
private: private:
/// Loaded modules list /// Loaded modules list
std::vector<std::shared_ptr<MscEngineModule>> _modules; std::vector<std::shared_ptr<MscEngineModule>> _modules;
+4 -2
View File
@@ -2,12 +2,14 @@
#define __MCS_ENGINE_MODULE_HPP__ #define __MCS_ENGINE_MODULE_HPP__
#include "engine/utils/rev_range.hpp" #include "engine/utils/rev_range.hpp"
#include "engine/core/engine_module_api.hpp"
#include <cstdint> #include <cstdint>
#include <string> #include <string>
#include <unordered_map> #include <unordered_map>
/// Engine module base class /// Engine module base class
class MscEngineModule { class MscEngineModule
{
public: public:
virtual ~MscEngineModule() = default; virtual ~MscEngineModule() = default;
@@ -22,7 +24,7 @@ public:
getDependencies() const = 0; getDependencies() const = 0;
/// Module initialization phase /// Module initialization phase
virtual void onInitialize(); virtual void onInitialize(IMscEngineModuleAPI &engine) = 0;
Review

не описан порядок вызова onInitialize

не описан порядок вызова onInitialize
Review

Да, я равновато onInitialize запихнул, потому что жизненный цикл буду делать в следующей ветке. Пока чисто положил его сюда, чтобы изучить сборку интерфейсов на плюсах))

Да, я равновато `onInitialize` запихнул, потому что жизненный цикл буду делать в следующей ветке. Пока чисто положил его сюда, чтобы изучить сборку интерфейсов на плюсах))
}; };
#endif // __MCS_ENGINE_MODULE_HPP__ #endif // __MCS_ENGINE_MODULE_HPP__
+2 -1
View File
@@ -3,7 +3,8 @@
typedef void UNIMPL; typedef void UNIMPL;
class IMscEngineModuleAPI { class IMscEngineModuleAPI
{
public: public:
virtual ~IMscEngineModuleAPI() = default; virtual ~IMscEngineModuleAPI() = default;
2
+4 -2
View File
@@ -2,9 +2,11 @@
#define __MSC_TEST_1_MODULE_HPP__ #define __MSC_TEST_1_MODULE_HPP__
#include "engine/core/engine_module.hpp" #include "engine/core/engine_module.hpp"
#include "engine/core/engine_module_api.hpp"
#include <cstdint> #include <cstdint>
class Test1Module : public MscEngineModule { class Test1Module : public MscEngineModule
{
public: public:
~Test1Module() = default; ~Test1Module() = default;
@@ -13,7 +15,7 @@ public:
const std::unordered_map<std::string, MscRevisionRange> & const std::unordered_map<std::string, MscRevisionRange> &
getDependencies() const override; getDependencies() const override;
void onInitialize() override; void onInitialize(IMscEngineModuleAPI &engine) override;
}; };
#endif // __MSC_TEST_1_MODULE_HPP__ #endif // __MSC_TEST_1_MODULE_HPP__
+4 -2
View File
@@ -2,12 +2,14 @@
#define __MSC_REV_RANGE_HPP__ #define __MSC_REV_RANGE_HPP__
#include <cstdint> #include <cstdint>
struct MscRevisionRange { struct MscRevisionRange
{
uint16_t minRevision; uint16_t minRevision;
uint16_t maxRevision; uint16_t maxRevision;
/// Check provided revision to be in range /// Check provided revision to be in range
bool isSatisfied(uint16_t rev) const { bool isSatisfied(uint16_t rev) const
{
return rev >= this->minRevision && rev <= this->maxRevision; return rev >= this->minRevision && rev <= this->maxRevision;
} }
}; };
+16 -8
View File
@@ -8,33 +8,40 @@
uint16_t MscEngine::REV = 0; uint16_t MscEngine::REV = 0;
MscEngine::MscEngine(std::vector<std::shared_ptr<MscEngineModule>> modules) { MscEngine::MscEngine(std::vector<std::shared_ptr<MscEngineModule>> modules)
{
std::unordered_map<std::string, uint16_t> registry; std::unordered_map<std::string, uint16_t> registry;
for (const auto &module : modules) { for (const auto &module : modules)
{
if (!module) if (!module)
continue; continue;
auto [it, inserted] = auto [it, inserted] =
registry.try_emplace(module->getName(), module->getRev()); registry.try_emplace(module->getName(), module->getRev());
if (!inserted) { if (!inserted)
{
throw std::runtime_error("Duplicate module detected: " + throw std::runtime_error("Duplicate module detected: " +
module->getName()); module->getName());
} }
} }
for (const auto &module : modules) { for (const auto &module : modules)
{
if (!module) if (!module)
continue; continue;
for (const auto &[dep_name, range] : module->getDependencies()) { for (const auto &[dep_name, range] : module->getDependencies())
{
auto it = registry.find(dep_name); auto it = registry.find(dep_name);
if (it == registry.end()) { if (it == registry.end())
{
throw std::runtime_error("Module " + module->getName() + throw std::runtime_error("Module " + module->getName() +
" requires missing module: " + dep_name); " requires missing module: " + dep_name);
} }
int current_rev = it->second; int current_rev = it->second;
if (!range.isSatisfied(current_rev)) { if (!range.isSatisfied(current_rev))
{
throw std::runtime_error( throw std::runtime_error(
"Module " + module->getName() + " requires " + dep_name + "Module " + module->getName() + " requires " + dep_name +
" in range [" + std::to_string(range.minRevision) + " <-> " + " in range [" + std::to_string(range.minRevision) + " <-> " +
@@ -49,6 +56,7 @@ MscEngine::MscEngine(std::vector<std::shared_ptr<MscEngineModule>> modules) {
UNIMPL MscEngine::getBus() const { throw std::runtime_error("Unimplemented"); } UNIMPL MscEngine::getBus() const { throw std::runtime_error("Unimplemented"); }
UNIMPL MscEngine::getLoadedModules() const { UNIMPL MscEngine::getLoadedModules() const
{
throw std::runtime_error("Unimplemented"); throw std::runtime_error("Unimplemented");
} }
+7 -2
View File
@@ -1,4 +1,5 @@
#include "engine/modules/test1/test1.hpp" #include "engine/modules/test1/test1.hpp"
#include "engine/core/engine_module_api.hpp"
#include "engine/utils/rev_range.hpp" #include "engine/utils/rev_range.hpp"
#include <cstdint> #include <cstdint>
#include <string> #include <string>
@@ -9,9 +10,13 @@ std::string Test1Module::getName() const { return "test1"; }
uint16_t Test1Module::getRev() const { return 1; } uint16_t Test1Module::getRev() const { return 1; }
const std::unordered_map<std::string, MscRevisionRange> & const std::unordered_map<std::string, MscRevisionRange> &
Test1Module::getDependencies() const { Test1Module::getDependencies() const
{
static const std::unordered_map<std::string, MscRevisionRange> deps{}; static const std::unordered_map<std::string, MscRevisionRange> deps{};
return deps; return deps;
} }
void Test1Module::onInitialize() {} void Test1Module::onInitialize(IMscEngineModuleAPI &engine)
{
(void)(engine);
}
+2 -1
View File
@@ -5,7 +5,8 @@
#include <stdlib.h> #include <stdlib.h>
#include <vector> #include <vector>
int main(int argc, char **argv) { int main(int argc, char **argv)
{
auto engine = auto engine =
std::make_unique<MscEngine>(std::vector<std::shared_ptr<MscEngineModule>>{ std::make_unique<MscEngine>(std::vector<std::shared_ptr<MscEngineModule>>{
std::make_shared<Test1Module>()}); std::make_shared<Test1Module>()});